[PEPr] Comment on Database::Sqlite_Tools

From: Date: Sat, 10 Jul 2004 23:01:56 +0000
Subject: [PEPr] Comment on Database::Sqlite_Tools
Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-31837@lists.php.net to get a copy of this message
David Costa (http://pear.php.net/user/gurugeek) has commented on the proposal for Database::Sqlite_Tools. Comment: Hans wrote : "I know the PEAR "way" is to use constants for error messages, but I wonder if it might not be clearer to just put the plaintext in your class. (Might also improve performance marginally not to have so many defines.)" Hello Hans, thanks for taking your time to commend my proposal. As suggested I did removed 5 of the constants that where used only once or could be replaced with an existing one. I agree it might make it clearer to have all the error messages near the relevant piece of code but I do prefer to keep the text messages all in one place ;) As you can imagine the users shouldn't have to spent to much to figure out which is what as the Pear_Exception system provides a pretty substantial trackback feedback and hopefully he would have no reason to change the errors output;) Regards David Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=105 -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#31837) next »