[PEPr] Comment on Networking::Net_NTP
| From: | PEPr | Date: | Wed, 21 Jul 2004 18:15:55 +0000 |
| Subject: | [PEPr] Comment on Networking::Net_NTP | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-32215@lists.php.net to get a copy of this message | ||
Martin Jansen (http://pear.php.net/user/mj) has commented on the proposal for Networking::Net_NTP.
Comment:
There are some minor coding standards issues aside from the ones that have already been mentioned by
Christian and Justin; e.g.:
define ("NET_NTP_RAW", 0); -> define("NET_NTP_RAW", 0);
$port=13, $timeout=8 -> $port = 13, $timeout = 8
TRUE/FALSE -> true/false
And I agree that you should make use of Net_Socket.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=108
--
Sent by PEPr, the automatic proposal system at http://pear.php.net