Re: Changes on Text_Huffman
| From: | Cipriano Groenendal | Date: | Thu, 22 Jul 2004 13:46:10 +0000 |
| Subject: | Re: Changes on Text_Huffman | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-32251@lists.php.net to get a copy of this message | ||
> Thanks voters for the feedback. I made my homework, so this is
> what I did according to your votes:
>
> 1. More comments (Justin Patrin)
> 2. Re-read coding guidelines and changed my code (Michael Wallner,
> Sérgio Carvalho, Stephan Schmidt)
> 3. Put protected members of base class final, changed protected
> methods in derived classes to private
> (Hans Lellelid, Bertrand Mansion)
>
> As a newbie: What happens now with the package?
Hi Markus
I see there were some conditional votes on the package, which now,
hopefully, have been satisfied by these recent changes.
Once the voting ends, the PEAR-group should contact these persons, to see if
they find their condition has been satisfied.
If you believe this has indeed been the case, you should mail the
PEAR-group, point out how these were fixed, and ask them for the correct
Karma to release your package on the website :)
HTH
Cipri