Re: [PEPr] Comment on Util::Util_Observable
| From: | Stephan Schmidt | Date: | Sat, 24 Jul 2004 09:04:05 +0000 |
| Subject: | Re: [PEPr] Comment on Util::Util_Observable | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-32297@lists.php.net to get a copy of this message | ||
Hi,
Heino H. Gehlsen wrote:
It's nice to see that see people are so convinced with PEAR, but how about a little class hunting? For starters there classes are not located according to the convention: SOAP_Attachment (located in SOAP/Value.php !), MDB2_Driver_Common and MDB2_Result_Common (both actually located in MDB2.php !), PEAR_Error, DB_Error, DB_Result, DB_Row, a lot of Net_SmartIRC_* and HTML_TreeMenu_*, XML_RPC_Base, XML_RPC_Client, XML_RPC_Response, SOAP_WSDL_Parser. Wow, I just had a WTF is the source code...If others made this mistake in the past, it's no excuse to do the same mistakes over again. A lot of these classes are located in the wrong files for performance issues. There already has been a discussion about this and the consensus was that classes used directly included by the user must follow the naming conventions. You will never require DB_Result, but I would count the interface definitions to the 'classes' that are required directly by the user, as he will want to take a look at the interface before implementing it. We do not use '__', if you want to use it, start a RFC, but you shouldn't wonder, if people complain about you using it in packages proposed in PEAR. Just my 2cts, Stephan