Re: ErrorStack

From: Date: Mon, 26 Jul 2004 03:56:36 +0000
Subject: Re: ErrorStack
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-32304@lists.php.net to get a copy of this message
Lukas Smith wrote:
Hi, I am looking at the ErrorStack code in detail for the first time. First thing CS police :-) You have a few tabs inside the code.
I'll fix that one easily enough :)
Now for the important bit. staticHasErrors() goes through all the registered objects. Wouldnt it be possible to "denormalize" the fact that one of the registered objects has errors when an error is pushed on the stack in order to prevent having to go through all the objects?
Yes. I have not attempted to optimize much, at least not until the API is the right one. There are other areas that could use a change too. I'll look at things soon. staticHasErrors() is the newest method, so I'm not surprised to hear it isn't perfectly thought-out :). By the way, I'm back. Canada was nice. Too many bugs though. Greg

« previous php.pear.dev (#32304) next »