[Patch] php4/pear/PEAR/Packager.php - Exposse error when no version information is found in package.xml
| From: | Markus Fischer | Date: | Sat, 01 Dec 2001 14:58:51 +0000 |
| Subject: | [Patch] php4/pear/PEAR/Packager.php - Exposse error when no version information is found in package.xml | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-3268@lists.php.net to get a copy of this message | ||
See subject and diff.
This prevents bogus packages like foo-.tgz being created.
- Markus
--
Please always Cc to me when replying to me on the lists.
Index: Packager.php =================================================================== RCS file: /repository/php4/pear/PEAR/Packager.php,v retrieving revision 1.20 diff -u -r1.20 Packager.php --- Packager.php 6 Nov 2001 00:22:18 -0000 1.20 +++ Packager.php 1 Dec 2001 14:51:03 -0000 @@ -117,6 +117,10 @@ if (isset($pkginfo['release_state']) && $pkginfo['release_state'] == 'snapshot') { $pkginfo['version'] = date('Ymd'); } + if (!isset($pkginfo['version'])) { + return $this->raiseError("No version information found in $pkgfile", + null, PEAR_ERROR_TRIGGER, E_USER_ERROR); + } // don't want strange characters $pkgname = ereg_replace ('[^a-zA-Z0-9._]', '_', $pkginfo['package']); $pkgversion = ereg_replace ('[^a-zA-Z0-9._\-]', '_', $pkginfo['version']);
Index: Packager.php =================================================================== RCS file: /repository/php4/pear/PEAR/Packager.php,v retrieving revision 1.20 diff -u -r1.20 Packager.php --- Packager.php 6 Nov 2001 00:22:18 -0000 1.20 +++ Packager.php 1 Dec 2001 14:51:03 -0000 @@ -117,6 +117,10 @@ if (isset($pkginfo['release_state']) && $pkginfo['release_state'] == 'snapshot') { $pkginfo['version'] = date('Ymd'); } + if (!isset($pkginfo['version'])) { + return $this->raiseError("No version information found in $pkgfile", + null, PEAR_ERROR_TRIGGER, E_USER_ERROR); + } // don't want strange characters $pkgname = ereg_replace ('[^a-zA-Z0-9._]', '_', $pkginfo['package']); $pkgversion = ereg_replace ('[^a-zA-Z0-9._\-]', '_', $pkginfo['version']);