Re: cvs: pear /Pager Common.php package.xml
| From: | Daniel Convissor | Date: | Thu, 19 Aug 2004 18:49:09 +0000 |
| Subject: | Re: cvs: pear /Pager Common.php package.xml | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-32769@lists.php.net to get a copy of this message | ||
Hi Lorenzo:
On Tue, Aug 17, 2004 at 02:45:57PM -0000, Lorenzo Alberton wrote:
> Modified files:
> /pear/Pager Common.php package.xml
> Log:
> prevent XSS attaks
... snip ...
> + $querystring = array_map('htmlspecialchars', $querystring);
Without looking at the source... Where is this data going? If it's
being used as a hyperlink or location header, shouldn't rawurlencode()
be used instead of htmlspecialchars()?
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409