Re: PEAR_Exception - some refactoring

Greg Beaver wrote: >Looks generally good - do you have commit access or would you like me to >take care of it? I used to have those rights but I am not sure anymore. My profile shows : pear peardoc pearweb php4/pear But maybe it is not up to date ? Would be nice if someone with enough karma could let me know. >Incidentally, I think people will need a getRawMessage() method to >retrieve the error message for logging purposes (all that html won't >look so good in a text file :) > >This would simply mean __toString() would call getRawMessage() if >$_SERVER['REQUEST_URI'] doesn't exist. Well, that's the idea. If you call __toString() in a non-web environment, the returned string is plain text (from the getTraceAsString() method). But a separate method might be usefull for logging as well, so I will take care of that. >The only other note is have you tested creating an exception in the >global context? I may be wrong, but I think getErrorMethod() would >cause a notice of undefined index 'function', same with the >getErrorClass(). Not that I would use this in the global context, but >it might as well work for completeness in case someone finds a good >reason to do so. You are probably right but I am not sure I get what you mean, could you please send me some example code so I can test and make the appropriate changes ? Thanks for taking the time to review it :) Bertrand Mansion Mamasam