[PEPr] Comment on Images::GraPHPite

Alexey Borzov (http://pear.php.net/user/avb) has commented on the proposal for Images::GraPHPite. Comment: Impressive! Unfortunately, you may have a harder than usual time pushing this into PEAR as we already have (sort of) a graph package. Fortunately, your effort beats Image_Graph hands down so opposition should be minimal. But before you have a chance to argue with "no competitive packages" defenders, you'll have to pass the CS police. I didn't look too closely at the package but here are some obvious Coding Standards violations. E.g. file Image/GraPHPite/axis/axislogarithmic.inc contains class Image_AxisLogarithmic. This should be Image/GraPHPite/Axis/Logarithmic.php and Image_GraPHPite_Axis_Logarithmic respectively. Classes and functions declarations do not follow "one true brace" convention. Private methods and variables are not prefixed by underscores. Also, your include.inc file loads almost *all* of the library, which is 800+ kb in size. Most PEAR packages implement some lazy loading scheme, where classes are loaded only when they are actually needed. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=145 -- Sent by PEPr, the automatic proposal system at http://pear.php.net