[PEPr] Comment on Images::GraPHPite
| From: | S�rgio Carvalho | Date: | Tue, 31 Aug 2004 11:20:42 +0000 |
| Subject: | [PEPr] Comment on Images::GraPHPite | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33110@lists.php.net to get a copy of this message | ||
Sérgio Carvalho (http://pear.php.net/user/sergiosgc) has commented on the proposal for
Images::GraPHPite.
Comment:
I've been taking it out for a spin. When E_NOTICE is enabled, the package
emits a few warnings, thrashing the image generation. The most common
offender is the test on the existence of gd2. Instead of: if
($GLOBALS['gd2']), it should be if (array_key_exists('gd2', $GLOBALS) &&
$GLOBALS['gd2'])
Since you'll be refactoring the package to deal with Coding Standards,
take some time to run it with maximum error verbosity and clean it up.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=145
--
Sent by PEPr, the automatic proposal system at http://pear.php.net