Re: [Patch] HTTP::absoluteURI() port redundancy

Turadg Aleahmad wrote:

Philippe, Sorry to beat this dead horse, but I thought it worth pointing out that in your example one could simply use HTTP::absoluteURI('file.zip', 'ftp') instead, sans port argument. But if the user does want to be redunantly specific and specify the port number, no need to override them. The problem I had was that the code was appending port 80 or 443 even when I didn't ask for it. As I pointed out in my previous message, it only does this when the protocol is 'http' or 'https'. -Turadg

Don't get me wrong, I completly agree with you that this was a bug. I just got a bit ticked off, because the original method I submitted didn't have that problem and had more features, regarding standard port numbers for some protocols. But, hey, that's open-source community, we can't expect all the code submitted to make the cut. Although it would be nice that no new bugs were introduced in the process. The example may have been clearer if I put it this way: config.php <?php $myFTPPort = 21; ?> download.php <?php HTTP::redirect(HTTP::absoluteURI('file.zip', 'ftp', $myFTPPort)); ?> Cheers, -Philippe