[PEPr] Comment on Database::DB_DataObject_Pager
| From: | Alan Knowles | Date: | Sat, 02 Oct 2004 04:13:32 +0000 |
| Subject: | [PEPr] Comment on Database::DB_DataObject_Pager | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33611@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for
Database::DB_DataObject_Pager.
Comment:
Good start - a few recomendations
- issolate all the options into a single options array (rather than
splattering the class with properties)
- try and avoid direct access to REQUEST/GET/POST - make the value of
these part of the constructor.
(it makes predicting what the class will do very poor)
- it would be good to render to various formats :
eg.
HTML_Table
data only - pager + array of dataobjects. this makes integration with
customer Tables / layouts easier..
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=157
--
Sent by PEPr, the automatic proposal system at http://pear.php.net