Re: Re: On private vars, inheritance and API design
| From: | Lukas Smith | Date: | Mon, 11 Oct 2004 08:13:38 +0000 |
| Subject: | Re: Re: On private vars, inheritance and API design | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-33759@lists.php.net to get a copy of this message | ||
Stefan Walk wrote:
On Sat, Oct 09, 2004 at 04:22:30PM +0200, Lukas Smith wrote:
Well... why do those methods have to be private in the first place? I scanned only quickly over the sources, and i saw no apparent reason for it...That is a good question. In MDB I pretty much just copied and merged the internals of DB and Metabase without much reflection of why. It was already enough work as it was :-) Now in MDB2 I have begung reviewing every line of code, but I am far from finished. If you have any comments in MDB2 then that would be greatly appreciated.
Btw, there seems to be a small error in peardb_wrapper.php - if i'm not mistaken there's a ->MDB_object missing in the first line of the quoteString method.no that was intentional regards, Lukas