[PEPr] +1 for PHP::PHP_Archive

From: Date: Mon, 06 Dec 2004 19:17:23 +0000
Subject: [PEPr] +1 for PHP::PHP_Archive
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-34849@lists.php.net to get a copy of this message
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for PHP::PHP_Archive. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=88 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=88&handle=justinpatrin This vote is conditional. The condition is: Pleas fix your indenting (I saw at least one place where two spaces were used instead of four) All functions that return values need @return in their docblocks. All var and function docblocks should have @access in them. Any private vars or functions should have '_' prepended to their names. It looks like most of the member vars should be private. I don't believe it's in CS, but I would prefer the docblocks be directly above their code (no extra line between the docblock and var or function). -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#34849) next »