[PEPr] +1 for Math::Math_Fraction
| From: | Justin Patrin | Date: | Wed, 08 Dec 2004 18:18:17 +0000 |
| Subject: | [PEPr] +1 for Math::Math_Fraction | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-34915@lists.php.net to get a copy of this message | ||
Justin Patrin (http://pear.php.net/user/justinpatrin) has voted +1 on the proposal for
Math::Math_Fraction.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=168
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=168&handle=justinpatrin
This vote is conditional. The condition is:
All operators should have spaces around them ($den=null and $n/$d).
Return and pass-by-ref should be removed unless you provide a compelling reason for keeping it in.
If for no other functions, for reduce and simplify this should be done as it may return the passed
in object *or* a new one. This could quite easily cause confusion.
Single quotes when requiring PEAR.php
(Optional) I would rather $n.'/'.$d than "$n/$d"
(Optional) Remove the fold markers. IMHO we shouldn't have all of the extra text in our code
for a small subset of editors which don't understand normal function folding semantics.
(Optional) If you keep the folding markers I would rather the end markers not be on the same line as
}.
If keeping fold markers, the opening fold marker for a class should have the class name in it.
--
Sent by PEPr, the automatic proposal system at http://pear.php.net