Re: AW: [PEAR-DEV] Net_SMTP - deadlock / robustness
| From: | Chuck Hagenbuch | Date: | Mon, 27 Dec 2004 17:27:22 +0000 |
| Subject: | Re: AW: [PEAR-DEV] Net_SMTP - deadlock / robustness | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35248@lists.php.net to get a copy of this message | ||
Quoting Matthias Pigulla <mp@webfactory.de>:
I think qmail is a little broken here, maybe it should return an error code for the first RCPT TO. However, that would make no difference as the problem is that we're sending two commands (because of the newline) but expect/process only one answer. I can't think of any other case where you might get two separate (that is, not the "mulitline" kind of) return codes, so making sure there's not return code left in the buffer seems to be overkill (that also might cause a lot of headache having to use nonblocking operations?). So, asserting (maybe at a very low level) that no command sent contains CRLF (except when in DATA mode) was the solution I had in mind, too. I was just unsure wheter it might break something else.Okay, please test this change: http://cvs.php.net/diff.php/pear/Net_SMTP/SMTP.php?r1=1.50&r2=1.51&ty=u -chuck -- "But she goes not abroad in search of monsters to destroy." - John Quincy Adams