[PEPr] Comment on Database::DB_NEWS

Louis Mullie (http://pear.php.net/user/louism) has commented on the proposal for Database::DB_NEWS. Comment: There are many problems with this proposal : Firstly, and most importantly, lack of abstractness; the task this attempts to solve is too specific IMHO, and the classes aren't really re-usable. This looks more like a web application : "there is another type of code that currently cannot be contributed to PEAR: Full web applications." (from the PEAR manual). This is enough to turn me down, but if however other developpers do not think like me, there are a few other problems which you should correct : - You use a custom template extension, which should definitely be changed to a PEAR template class. - It requires DB.php which is unexistent. - The function naming uses underscores i.e. add_news should be addNews - It doesnt use PEAR error handling consistently. Finally, it uses some procedural functions which should have been implemented in the main class. Just doesn't cut it for me. Sorry. Regards, Louis Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=148 -- Sent by PEPr, the automatic proposal system at http://pear.php.net