Re: please test XML_RPC version 1.2.0RC2
| From: | Helgi Þormar | Date: | Wed, 12 Jan 2005 13:49:51 +0000 |
| Subject: | Re: please test XML_RPC version 1.2.0RC2 | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35464@lists.php.net to get a copy of this message | ||
On Wed, 2005-01-12 at 01:46, anatoly techtonik wrote:
> Hello Daniel,
>
> DC> I just rolled XML_RPC 1.2.0RC2. Please test it out.
>
> Well, I'm trying to integrate this package source with my patched version.
> I don't remember correctly which one of bugreports explained this behavior,
> but check this code fragment I've added some months ago. Due to the time
> passed now I can't correctly remember why I had added this, but surely to
> solve some problem. It is situated around line 213 in your source.
> Shouldn't be something too complicated. Solution is already here.
> Have fun.
>
> ....
> case "MEMBER":
> $XML_RPC_xh[$parser]['ac'] = "";
> break;
>
> default:
> + $XML_RPC_xh[$parser]['ac'] = "";
> break;
> }
IMHO it's much cleaner to do this:
case "MEMBER":
default:
$XML_RPC_xh[$parser]['ac'] = "";
break;
}
Give the same output and well less lines :)
- Helgi