[PEPr] +1 for Web Services::Services_Yahoo
| From: | Philippe Jausions | Date: | Tue, 15 Mar 2005 19:57:30 +0000 |
| Subject: | [PEPr] +1 for Web Services::Services_Yahoo | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36692@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has voted +1 on the proposal for Web
Services::Services_Yahoo.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=221
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=221&handle=jausions
Comment:
Very nice. Just a couple of notes though:
Fix path for require_once 'AbstractSearch.php';
in the search service classes.
and I think it would be more explicit to rename the setResults() method to
setMaxResults(). The latter doesn't need explaination, while the former
makes you wonder a bit what it's supposed to be doing...
Otherwise, very nice PHP5 use...
-Philippe
--
Sent by PEPr, the automatic proposal system at http://pear.php.net