Re: Re: cvs: pear /Net_Cyrus Cyrus.php package.xml test_cyrus.php

On Fri, 2005-04-08 at 09:49 -0400, Daniel Convissor wrote: > Hi Damian (and everyone): > > How about getting coding standards issues straightened out before making > initial commits? This way the repository doesn't have to contain all > sorts of changes and everyone on the lists don't have to read of them. I've already asked him to fix this, we can't always think that people will fix some peasky CS in first commit, I find it much more important to get the code inside the repo then delaying it because of few CS issues. Those are all old packages he committed so it's not strange they have some issues, since they have never been in the repo before, you sometimes have to take stuff like that into account. > For example, use the new header comment blocks, use consistent/proper > nesting for the docblocks, provide complete docblocks, ditch all of > the extra spacing between methods, etc. Applying the new header thing can be time consuming and really isn't needed until the package does a release, no ? At least no need to get all worked up if they lack for couple of commits :-) - Helgi