Re: Re: DB_DataObject bug (IMHO): table($table) method and INI file storage

On Apr 10, 2005 6:44 AM, Alan Knowles <alan@akbkhome.com> wrote: > insert and update should use table() really (can you file that as a > bug), although looking at that specific case, I suspect you may want to > use explicit setters/getters and not get too clever with doing stuff in > the background. I mentioned this a while ago and you instead made it pull from the ini file first and then from table(). If DB_DO internally uses table() always instead of the INI settings then it gets much easier to do clever things. Same goes for keys() and links() (and sequenceKey()). > > Regards > Alan > > > On Sun, 2005-04-10 at 14:42 +0200, Stijn de Reede wrote: > > Hmm... I just realized my field hack won't work, since update() and > > insert() will generate SQL for non-existing fields. I think I ned to > > overwrite the insert() and update() method, to update the fields there. > > But still, it's something to think about, where should the overridden > > table definitions be used? > > > > > > Stijn > > > > > > > > Stijn de Reede wrote: > > > > > Hi all, > > > > > > I've come across a small problem with DB_DataObject. I'll describe my > > > situation first. > > > I creating a CMS with multiple language support. The fields in de table > > > will be something like: name_en, name_nl, name_de, etc. So the name of > > > the field with an underscore and the language appended. The template > > > layer of frontend and backend part of CMS will still be using > > > name, > > > without the language. I'm trying to extend the DB_DataObject classes, so > > > references will be made to the correct fields (depending on a session > > > language var). > > > I've created the following function in my DB_DataObject: > > > > > > function referenceLanguage() { > > > $vars = get_object_vars($this); > > > foreach ($vars as $var => $value) { > > > if (substr($var, -3) == > > > '_'.$_SESSION['c']['language']['edit']) { > > > $newvar = substr($var, 0, -3); > > > $this->$newvar =& $this->$var; > > > } > > > } > > > } > > > > > > I'm calling this function from the contructor. In the contructor, I also > > > update the table definition for the object with > > > > > > $table = $this->table(); > > > foreach ($table as $var => $type) { > > > if (substr($var, -3) == > > > '_'.$_SESSION['c']['language']['edit']) { > > > $table[substr($var, 0, -3)] = $type; > > > } > > > } > > > $this->table($table); > > > > > > > > > *Now, here comes the problem*: the update() and insert() methods use the > > > cached INI file, instead of the updated table difinition (code from > > > DataObject.php: > > > > > > $items = > > > isset($_DB_DATAOBJECT['INI'][$this->_database][$this->__table]) > > > ? $_DB_DATAOBJECT['INI'][$this->_database][$this->__table] : > > > $this->table(); > > > > > > The setFrom method doesn't do this, and only uses the table() method. I > > > think all methods should use the table() method, since otherwise > > > updating your table definition manually isn't really useful. > > > > > > > > > > > > *Then another related problem:* > > > As you saw, I created refereces to the correct fields with the correct > > > language. Since I'm using HTML_Template_Xipe, I want to collect multiple > > > result rows in an array within PHP, and then walk over the array in the > > > template. Like so: > > > > > > $content_text = DB_DataObject::factory('Content_text'); > > > $content_text->find(); > > > $content_texts = array(); > > > while ($content_text->fetch()) { > > > array_push($content_texts, $content_text); > > > } > > > > > > But this creates a problem. Firstly the contructor isn't called for each > > > fetch, so the referenceLanguage() method isn't called either. This can > > > be resolved by overriding the fetch() method and adding the > > > referenceLanguage() call their. But this still doesn't solve the problem > > > because the references to the language fields remain the same references > > > when pushing the object onto the array. Meaning... > > > name references the > > > last name_en field for all the objects in the array. > > > PHP makes a shallow copy of the object, keeping the references. How can > > > I solve this problem? Overwriting the the __clone() method isn't quite > > > right I think... > > > > > > > > > > > > Regards, > > > > > > Stijn > > > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Justin Patrin