Re: cvs: pear /PEAR_Delegator/source Delegator.php package.xml
| From: | Daniel Convissor | Date: | Mon, 18 Apr 2005 14:16:56 +0000 |
| Subject: | Re: cvs: pear /PEAR_Delegator/source Delegator.php package.xml | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37271@lists.php.net to get a copy of this message | ||
Hi Michael:
On Mon, Apr 18, 2005 at 12:25:05AM -0000, Michael Witten wrote:
> herrwitten Sun Apr 17 20:25:05 2005 EDT
> Added files:
> /pear/PEAR_Delegator/source Delegator.php package.xml
Excellent job. A few minor pieces of feedback...
> // /* vim: set expandtab tabstop=4 shiftwidth=4: */
> // +----------------------------------------------------------------------+
> // | PHP Version 5 |
> // +----------------------------------------------------------------------+
Remove the entirety of the old docblock format.
> * @since PHP 5.0.0
> * @author Michael Witten <LingWitt@yahoo.com> 4100 85
> * @see http://pear.php.net/manual/
> * @package PEAR_Delegator
> */
> class PEAR_Delegator
Please use the format specified in the coding standards. Also, the
purpose of @since is for which version of the package the current object
was added (though it's not used for items in the package from the
beginning).
> }
> else {
Here, and perhaps elsewhere, you use this format.
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409