Re: Fwd: [PEAR] Some tweaks to DB_DataObject

> It's a good idea to > a) update your codebase with the one from CVS, there have been bugs I guess I should start from the beggining again then ? > fixed that your diff would removed. > b) try and make one change at a time, and make a diff for it. > Sorry please dont tell me to RTFM, i am not good with diffing or merging, thanks for showing me how to diff from cvs, but how to i merge into my current version ? I use eclipse, it has some merge features ? >>From the patch > - extra variable searchLogic : this seems rather dangerous, If you need > to do something like this, then wrapping Dataobjects and adding a > method whereOr(...) would be better.(also remember by adding > setLogic(), you just broke setFrom with columns called Logic..) > *blushes* , let me go over it on the weekend. My explanation is that I am trying to use setFrom to build a search filter from form data for search and displaying a data grid. Your current setFrom was not checking for empty values, but maybe that was an issue on my end :| Lemme find out. > - not sure why you would want explicit rollback etc. it makes a fat API > even fatter.. > Hence why I had asked about rollback and how to handle it on errors , if rows or inc id were not returned etc ..