Re: [PEPr] Proposal for Math::Math_PDL
| From: | Ants Aasma | Date: | Thu, 05 May 2005 12:53:16 +0000 |
| Subject: | Re: [PEPr] Proposal for Math::Math_PDL | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37497@lists.php.net to get a copy of this message | ||
I think the package is useful. Especially for those who are writing
web-based games. But the quality seems to be somewhat lacking in places.
At least BinomialDistribution, which was the one I tested, was broken
for trials > 25. The constant PI should be M_PI, the $nold/$pold code is
useless if the results aren't cache and $n in if ($n != $nold) is
uninitalized. If you're intrested in the fixed code, e-mail me.
Also, I think the special functions, such as gamma()/logGamma(), should
be namespaced into static methods and maybe even put into a separate
package. Math_Functions or something of that sort maybe?
Otherwise, great work!
----------
Ants Aasma