[PEPr] Comment on Tools and Utilities::ScriptReorganizer
| From: | Vincent Lascaux | Date: | Mon, 16 May 2005 13:46:54 +0000 |
| Subject: | [PEPr] Comment on Tools and Utilities::ScriptReorganizer | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37677@lists.php.net to get a copy of this message | ||
Vincent Lascaux (http://pear.php.net/user/vincentlascaux) has commented on the proposal for Tools
and Utilities::ScriptReorganizer.
Comment:
I find the general idea good...
I don't think Type is a good name, Document would probably be better (if I
understand what it does right: storing the document (script or library)
that will be transformed by a strategy).
About the design itself, I think that the decorators should be strategies
(since they just modify the script, exactly like strategies do), and I
don't think the Type (or Document) should hold the strategies: strategies
should be applied on documents, something like
$strategy->transform($document)
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=247
--
Sent by PEPr, the automatic proposal system at http://pear.php.net