[PEPr] +1 for Networking::Net_Wifi

From: Date: Sun, 22 May 2005 04:07:02 +0000
Subject: [PEPr] +1 for Networking::Net_Wifi
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-37787@lists.php.net to get a copy of this message
Alan Knowles (http://pear.php.net/user/alan_k) has voted +1 on the proposal for Networking::Net_Wifi. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=248 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=248&handle=alan_k This vote is conditional. The condition is: Very quick review: - please use escapeshellarg() where ever exec is used... - unless it would break things.. (then at least make notes to such) - try using System::which() to discover /usr/sbin/iwconfig etc... in the constructor (normally for something like this I would have done var $cmds = array( 'ifconfig' => ..... , 'iwconfig' => .....) Groups related variables together , and concentrates code and documentation in a smaller more relivent group. -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#37787) next »