Re: cvs: pear /File_Archive Archive.php /File_Archive/Archive Reader.php /File_Archive/tests test.php
| From: | Daniel Convissor | Date: | Mon, 23 May 2005 18:43:45 +0000 |
| Subject: | Re: cvs: pear /File_Archive Archive.php /File_Archive/Archive Reader.php /File_Archive/tests test.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-37809@lists.php.net to get a copy of this message | ||
Hi Vincent:
On Sun, May 15, 2005 at 12:13:20AM -0000, Vincent Lascaux wrote:
> vincentlascaux Sat May 14 20:13:20 2005 EDT
>
> Modified files:
> /pear/File_Archive Archive.php
> /pear/File_Archive/Archive Reader.php
> /pear/File_Archive/tests test.php
...
> + if(PEAR::isError($source)) {
Nit pick... Here, and in some other places, you're not putting spaces
between your control structure keywords (if, switch, etc) and opening
parentheses. Should be like:
if (PEAR::isError($source)) {
Thanks,
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409