Re: Re: cvs: php4(PHP_4_0_6) /pear/Cache OutputCompression.php
| From: | Christian Stocker | Date: | Tue, 15 May 2001 07:09:28 +0000 |
| Subject: | Re: Re: cvs: php4(PHP_4_0_6) /pear/Cache OutputCompression.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-383@lists.php.net to get a copy of this message | ||
Hi
> In instances like this, I generally prefer to resort to the
> language rule of avoiding double-negatives. In the above case,
> we're looking at "if not no_cache" when it could more plainly be
> written as "if cache" (if the inverse being "if not cache", as
> opposed to "if no_cache"). In my opinion, this is much clearer
> when read in context.
yes, it's clearer. but one reason against changing this is, that we then
have a api-change... not a big one, but nevertheless it's one....
and a lot of code has to be changed in Cache.php as well, otherwise it
will be broken.
As a temporary measure against the api change, we could write a
compatibility-line like
if ($this->no_cache == True) {$this->caching = False}
somewhere at the end in setoptions() in Container.php and write into the
docu that no_cache soon not will be supported anymore
chregu
--
nam...christian stocker adr...bremgartnerstr. 66, ch-8003 zurich
pho...+41 1 451 6021 www...http://phant.ch/chregu
mob...+41 76 561 8860 ema...chregu@phant.ch