Re: Net_Curl bug fixes / status

On Wednesday 13 July 2005 04:56 pm, Joe Stump wrote: > 1.) The {{{ / }}} are code folding for vim (and others?). They are > present throughout a lot of the PEAR code. Including PEAR.php. They > may not be in the CS per se, but it's somewhat implied and not any > more of a major issue than the vim rules that appear in some code as > well. BTW, the vim rules are even in the example code. Hrm. Actually, > the code folding appears in the sample file as well: http:// > pear.php.net/manual/en/standards.sample.php > I see. My editor automagically folds at braces. I've always wondered what those things were, they seem like a lot of effort to maintain. > 3.) True, it does not, but the majority of the code written in PEAR > fullows humpBack, as did many of the variables and functions in > Net_Curl. This lead to inconsistency within the package and went > against common practices in PEAR (even if it's no CS per se). > Considering how broken the previous Net_Curl package is/was and the > fact that only one package relies on this I think it's fine to break > BC in this case. > Version naming policy[1] states: "BC may only be broken in releases that have a version number of "x.0.0" with a state lower than stable or that have a version number below "1.0.0". As a converse only releases that break BC or that have a version number of "1.0.0" may increase the major version number compared to the previous release." > 4.) Yup. Not my code, but it was valid code. Also, I believe 3xx > codes are for redirections, which is a non-issue for Net_Curl since > it is set up to follow location, thus the *final* code should either > be a 2xx or some error code (4xx or 5xx). I'll update the code just > to be safe as I find your suggestion a cleaner implementation. > Actually, in a later patch you'll note that I *do* use the substr(), > but don't check for 3xx. > So what happens on the first request where you get the 30x? Does it return a PEAR_Error? What if follow_location isn't set? [1]: http://pear.php.net/group/docs/20040226-vn.php

Attachment: [application/pgp-signature]