[PEPr] Comment on Console::Console_Wizard
| From: | Bertrand Mansion | Date: | Sun, 17 Jul 2005 08:57:05 +0000 |
| Subject: | [PEPr] Comment on Console::Console_Wizard | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38677@lists.php.net to get a copy of this message | ||
Bertrand Mansion (http://pear.php.net/user/mansion) has commented on the proposal for
Console::Console_Wizard.
Comment:
First impressions:
CS issues:
- Instance variables should use camelCase IMO.
Suggestions:
- Index types should be setable on a per question basis.
- the constructor and singleton() should accept an option/configuration
array.
- addQuestion should accept be 3 parameters max, the third one being an
option array (to prevent future API problems)
- maybe do the same with addRule(), unless you are sure it won't change.
- It should be possible to use a previous answer to setup the next
questions. A page system like in QFC might work.
- What about an xml wizard definition ?
- Make sure every text is localizable.
- addGroupRule() is empty
I haven't run the examples yet, I'll let you know later.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=273
--
Sent by PEPr, the automatic proposal system at http://pear.php.net