[PEPr] Comment on Web Services::Services_DynDNS
| From: | Philippe Jausions | Date: | Thu, 21 Jul 2005 17:25:27 +0000 |
| Subject: | [PEPr] Comment on Web Services::Services_DynDNS | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-38824@lists.php.net to get a copy of this message | ||
Philippe Jausions (http://pear.php.net/user/jausions) has commented on the proposal for Web
Services::Services_DynDNS.
Comment:
In DynDNS.php:
- I believe "self::" is PHP5 only (getUserAgent() and setUserAgent())
- What's the point of the "static" in apiVersion()?
- In sendRequest, I would say "Unexpected HTTP response code" instead of
"invalid http response code"
- In _userAgent(), better test for "$value === false"
- DocBlock updates:
+ @return for getUserAgent(),
+ @return PEAR_Error|Services_DynDNS_Response for sendRequest()
In Request::factory() method, add basename() around strtolower($type) to
avoid directory transversal.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=274
--
Sent by PEPr, the automatic proposal system at http://pear.php.net