Re: cvs: pear /Image_3D/Image 3D.php
| From: | Daniel Convissor | Date: | Sun, 31 Jul 2005 11:53:38 +0000 |
| Subject: | Re: cvs: pear /Image_3D/Image 3D.php | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-39057@lists.php.net to get a copy of this message | ||
On Sun, Jul 31, 2005 at 10:57:56AM -0000, Kore Nordmann wrote:
>
> + /**
> + * Backgroundcolor
> + */
> protected $_color;
Your properties and methods were nested with tabs. Spaces are to be used
in PEAR. Example:
/**
*
*/
protected $_color;
Plus, you need to describe the data types.
> + /**
> + * Factory method for Objects
> + *
> + * Creates and returns a printable object.
> + * Standard objects with parameters:
> + * - cube array(x, y, z)
> + * - sphere array(r, detail)
> + * - 3ds file
> + * - map [array(array(Image_3D_Point))]
> + * - text string
> + *
> + * @param string Objectname
> + * @param array Parameters
> + * @return Image_3D_Object Object instance
> + * @author Kore Nordmann <3d@kore-nordmann.de>
> + * @version 0.1
> + */
Get rid of the @author and @version tags from the method definitions.
They just belong in the class and file docblocks.
Please go back to the sample file in the manual's coding standards
section and read the whole thing very carefully.
--Dan
--
T H E A N A L Y S I S A N D S O L U T I O N S C O M P A N Y
data intensive web and database programming
http://www.AnalysisAndSolutions.com/
4015 7th Ave #4, Brooklyn NY 11232 v: 718-854-0335 f: 718-854-0409