Re: Net_IDNA_php5

From: Date: Thu, 11 Aug 2005 15:40:09 +0000
Subject: Re: Net_IDNA_php5
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-39323@lists.php.net to get a copy of this message
Hi Markus, Where is your repository? The only repo where i found is the repo on docuverse but the files there are over 11 monthes old. In the php5 class, there is no implementation of the _error() function. The only thing is a public var called $_error and your error handling uses the _error *function*. This means, on an error, you get a Fatal Error due an undefined method. Now you should add an _error function like the php4 class or (whats my favorit) use exceptions for error handling. On Thu, 2005-08-11 at 06:32 +0200, Markus Nix (Mayflower) wrote: > Hi Benjamin, > > I got CVS access much later than my PEAR account. Therefore, > we check it out from our own repository. > > I am pretty sure that you gained a mission target with > Net_IDNA, but your patches are pretty much yadda yadda. > Maybe we use Exceptions in a later version, maybe not. > That libidn is faster than the PEAR package is a trivial > statement too, nothing else was expected. I have no clue what > you want to say. > > Regards, > > Markus >

« previous php.pear.dev (#39323) next »