Re: [PEPr] +1 for Tools and Utilities::CodeGen_MySQL_UDF

On Tue, 06 Sep 2005 19:02:45 +0200, Hartmut Holzgraefe <hartmut@php.net> wrote:

Stefano F. Rausch wrote:

this has already been taken care of in http://hartmut.homeip.net/CodeGen_MySQL_UDF-0.9.1dev.tgz

Fine. However, please be so kind to adopt the http://pear.php.net/manual/en/standards.sample.php, http://pear.php.net/manual/en/standards.file.php and others in all details, e.g. change the header comment block ("page-level" docblock) to the new format,

done

add the missing LF after the closing PHP tag at the end of the files

done

etc. ... sorry to be hard work.

and "etc. ... " is?

I won't go too much into detail, for the remarks are more cosmetic ones - just the main "2 cents": - it would be nice to have more concise comments for the files you're including in CodeGen_MySQL_UDF_Extension, CodeGen_MySQL_UDF_ExtensionParser and CodeGen_MySQL_UDF_Element_Function and not only a plain "includes", that's obvious ... ;-) - why do you mix up the location (and that even several times within one class) of the properties and the operations (methods) in both CodeGen_MySQL_UDF_Extension and CodeGen_MySQL_UDF_Element_Function? I've never seen this style before. It is somehow irritating not to have all properties being declared/grouped either at the beginning or - as an viable alternative - at the end of the respective class.

the changes above are in http://hartmut.homeip.net/CodeGen_MySQL_UDF-0.9.2dev.tgz together with the now completed manual.html

Best regards -- Stefano