[PEPr] Comment on Web Services::Services_ABR

bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for Web Services::Services_ABR. Comment: Looks fine, I like the optional cache. Some little remarks: * headers are not correct, you should use something like (About PEAR-->Coding Standards) : * @param string $arg1 the string to quote * package.xml: <name>Daniel O&apos;Connor</name> is not correct, ues numeric entities. * in _general() : $filename = $filename . implode("_", $options); Is it not safer to put a '_' before the options ? You have a problem if no options are transmitted (null) as then you do: $options = $chief_param; which is a string. * don't use $this->_cache->save($value); without $id ($filename), it's potentially dangerous. * _checkOptions() Your return is not initialized if no options passed * _sendRequest() is it not possible to use something like $this->_request->setURL() instead or re-instanciate an HTTP_Request object each time ? Bon courage :) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=302 -- Sent by PEPr, the automatic proposal system at http://pear.php.net