[PEPr] Comment on File Formats::iCal
| From: | Daniel O'Connor | Date: | Fri, 07 Oct 2005 00:15:25 +0000 |
| Subject: | [PEPr] Comment on File Formats::iCal | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40110@lists.php.net to get a copy of this message | ||
Daniel O'Connor (http://pear.php.net/user/doconnor) has commented on the proposal for File
Formats::iCal.
Comment:
Version @ http://www.akbkhome.com/svn/akpear/File_iCal
<?php
require( "File/iCal.php" );
$iCal = new File_iCal();
//$iCal->sendHeader();
$cal = $iCal->getSkeletonCalendar();
$c = $iCal->factory("Event",
array("dateStart" => time(),
"dateEnd" => time() + 60*60*24,
"Description" => "Valuation Appointment @
Address foo with contact x y z"
)
);
$cal->addEvent($c);
$iCal->addCalendar($cal);
print $iCal;
?>
... causes apache to crash.
PHP 5.05; Apache 2.0.3; Winxp.
Other nitpicking:
Methods like File_iCal_iCalendar::addComponent() should error if a
component is added that does not comply with File_iCal_Component.
[For instance, adding an instance of File_iCal_Event via addComponent()
seemed perfectly reasonable, but caused errors later on - principle of
least surprise]
It would be nice to have some examples of usage; and more complete
javadocs - sing out if you'd like a hand in that regard.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=251
--
Sent by PEPr, the automatic proposal system at http://pear.php.net