[PEPr] +1 for Images::MonoBMP

From: Date: Sat, 08 Oct 2005 06:37:03 +0000
Subject: [PEPr] +1 for Images::MonoBMP
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-40112@lists.php.net to get a copy of this message
Andrew Morton (http://pear.php.net/user/drewish) has voted +1 on the proposal for Images::MonoBMP. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=296 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=296&handle=drewish Comment: Looks good but a couple of small things occurred to me: * In output() you've got a branch for for if ($filename === false). Rather than calling echo, you could set filename = 'php://output' and use the same fopen()/fwrite()/fclose() code. * It's not critical but I'd like to see more comments in output() and createFromFile() on the file format. * It appears that you've corrected just about everything Justin Patrin mentioned other than a couple of the "BM"s (rather than 'BM'). -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#40112) next »