Re: BBCodeParser (CVS commit(s))
| From: | Lorenzo Alberton | Date: | Mon, 17 Oct 2005 18:01:55 +0000 |
| Subject: | Re: BBCodeParser (CVS commit(s)) | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40217@lists.php.net to get a copy of this message | ||
Seth Price wrote:
It looks fine with me. Test cases still work... Some of your commenting changes, although harmless, seemed unnecessary. Other commenting changes (using // with multiline comments) go against what I have heard is good style.well, I've only changed one- or two-lines comments because if you need to comment a block of code around them you can, this way. I left multiline comments as-is. Best regards, -- Lorenzo Alberton http://pear.php.net/user/quipo