Re: HTML_Table bug

On Tue, 25 Oct 2005 10:17:18 +0200, Bertrand Mansion wrote: > Hi, > > I got this report this morning: > >>FYI: The latest release of HTML_Table 1.6 has the following function >>defined. Note that you reference variables in the internal call to >>updateRowAttributes that you are not passing in. >> >> >> /** >> * Adds a table column and returns the column identifier >> * @param array $contents (optional) Must be a indexed >>array of valid cell contents >> * @param mixed $attributes (optional) Associative array >>or string of table row attributes >> * @param string $type (optional) Cell type either >>'th' or 'td' >> * @return int >> * @access public >> */ >> function addCol($contents = null, $attributes = null, $type = 'td') >> { >> return $this->_tbody->updateRowAttributes($row, $attributes, >>$inTR); >> } >> >> >>Not sure how this version got labeled as 'stable' > > If you can't make sure that what you release is stable, don't mark it stable. > People are actually using the package on production sites, so be careful. If you > are too busy or not competent enough to make sure everything is ok, make an > HTML_Table2 package as I suggested before and mark it alpha or beta. Thanks. Well I trusted Mark to do all the testings and such as I asked him to prepare this release, I did a short look over at the code and runned it, but as I don't have any of the ref fixing PHP versions then I didn't catch it. Now if you are unhappy with this then just remove me and Mark as developers and revert this version, I don't really care as I don't have much time for this, I simply did the release, might I suggest that you actually become active again and handle this if you want to care about this package at all ? - Helgi