Re: Vote Details for "Math_Polynomial" by arnaud

Keith Palmer Jr. wrote: > Arnaud: > > I believe I fixed the coding style issues you had with my > Math_Polynomial proposal, thanks for the thoughts. > > As far as the get_class($obj) calls though, any place I do this I am > comparing the result from get_class($obj) to get_class($this), so they > should both be case-sensitive, and there really is no reason to use > strtolower() in these cases. > > If I was doing: > if (get_class($obj) == "polynomial") > > then it would be a different story... but I don't see any problem with: > > if (get_class($obj) == get_class($this)) > > ...do you? Indeed, you are right, I had overlooked that. I voted zero because I do not know the subject well enough to have a significant opinion but I do think this package can be useful to some people. Arnaud.