Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Parser.php
| From: | Mark Wiesemann | Date: | Sun, 20 Nov 2005 17:27:55 +0000 |
| Subject: | Re: cvs: pear /Spreadsheet_Excel_Writer/Writer Parser.php | ||
| References: | 1 2 | Groups: | php.pear.cvs php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40444@lists.php.net to get a copy of this message | ||
Daniel Convissor wrote:
> On Fri, Nov 11, 2005 at 02:51:09PM -0000, Xavier Noguer Gallego wrote:
>> Modified files:
>> /pear/Spreadsheet_Excel_Writer/Writer Parser.php
> ...
>> - while (($this->_current_token == SPREADSHEET_EXCEL_WRITER_ADD) ||
>> + while (($this->_current_token == SPREADSHEET_EXCEL_WRITER_ADD) or
>
> Forgot to mention this earlier. PEAR standards use "||" not "or".
Is this documented somewhere or is it just meant as "we prefer to use ||
instead of 'or'"?
I know a package that widely uses 'and' and 'or', and it maybe should be
changed there ...
Mark
X'Post: php.pear.cvs,php.pear.dev