Re[2]: [PEAR-DEV] Re: File_SearchReplace API and versioning

Hello Arnaud, From Sunday, December 4, 2005, 7:07:32 PM, you wrote: AL> anatoly techtonik wrote: >> Hello Lukas, >> >> From Sunday, March 13, 2005, 10:01:14 PM, you wrote: >> >>>> The only problem with API is that now replacement is done by default. >>>> After modification it will be done explicitly. It is sure a BC break, >>>> but how to estimate the impact? >> >> LS> The impact is that you need to create a new major version, which >> LS> effectively means creating a new package called File_SearchReplace2. >> LS> However it sounds more like you should handle this through options, >> LS> optional parameters or an additional method than with a new package. >> >> I can't handle this through options, because I need to change default >> behavior to make the use of package easy and safe. This is explained >> here: >> http://pear.php.net/pepr/pepr-comments-show.php?id=281 >> >> It seems to me, that I've found the solution. >> http://pear.php.net/group/docs/20040226-vn.php >> >> I will release latest 1.1.0 version without Search capability and then >> will make 2.0.0 release. Is it ok? >> >> t AL> Nope, breaking BC is not allowed. You want to change a default behaviour AL> and that does not make sense. AL> If it is document then replace occurs and to have search one just need AL> to set an option I do not see what the problem is. AL> Arnaud. Please answer this questions for me without reading package docs just to understand your POV. Does "doSearch(false)" construction make sense for you? What should it do if it does? Is it obvious for everybody else? What should doSearch() do in your opinion _by default_ in a package with doReplace() method? t --