[PEPr] Comment on File Formats::File_BMF
| From: | Alan Knowles | Date: | Fri, 13 Jan 2006 01:18:09 +0000 |
| Subject: | [PEPr] Comment on File Formats::File_BMF | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40953@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for File
Formats::File_BMF.
Comment:
couple of other things:
- encode/decode are more obvious names than bmencode/bmdecode.
- can you not create an instance in encode/decode and call
$bmf->_hex2bin() etc. - making the whole class static seems a bit of a
pain.
- bmencode/decode file - is a bit of an overkill for
File_BMF::encode(file_get_contents(....));
- avoid using @ where possible...
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=306
--
Sent by PEPr, the automatic proposal system at http://pear.php.net