Re: Proposal of new package Services_AudioScrobbler
| From: | David Grant | Date: | Thu, 19 Jan 2006 15:10:44 +0000 |
| Subject: | Re: Proposal of new package Services_AudioScrobbler | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40989@lists.php.net to get a copy of this message | ||
Hi Dan,
I've recently committed a XSPF package to the PEAR repository, which you
might like to use in some way in your package as an option (AS offers
XSPF as well as straight XML).
http://pear.php.net/package/File_XSPF
Dan Rossi wrote:
> The source code is here
>
>
> http://www.electroteque.org/pear/Services_AudioScrobbler/index.phps
>
> http://www.electroteque.org/pear/Services_AudioScrobbler/AudioScrobbler.phps
>
> Please dont be too harsh, but harsh feedback welcome, im new at
> proposing PEAR packages, some of the design is modelled from other
> Services packages.
One point I might make is that I would prefer the service keys to be
constants, rather than strings.
David (djg on AS)
--
David Grant
http://www.grant.org.uk/
http://pear.php.net/package/File_Ogg 0.2.1
http://pear.php.net/package/File_XSPF 0.1.0