[PEPr] Comment on Images::Puzzle
| From: | Christian Weiske | Date: | Fri, 10 Feb 2006 05:53:56 +0000 |
| Subject: | [PEPr] Comment on Images::Puzzle | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41279@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has commented on the proposal for
Images::Puzzle.
Comment:
A nice and fun package I'd like to see in PEAR.
Some notes:
- Could you please provide some .phps files so that lazy pear people get a
look?
- The package tgz is missing an example (you probably can use the one from
the proposal on your sever)
- require_once shouldn't be used with braces
- speling mistake in the docblock of _setPictures
- You mixed tab and space indentation. That looks weird if you have tab
size set to != 4, and spaces are required by PEAR CS (Main class)
- You're mixing PEAR_Exception (Main class) and PEAR_Error (Piece.php)
- It would be cool if you could save the pieces in one file each.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=349
--
Sent by PEPr, the automatic proposal system at http://pear.php.net