[PEPr] Comment on Math::Math_AP_(Re-proposal)
| From: | bertrand Gugger | Date: | Sat, 04 Mar 2006 14:06:10 +0000 |
| Subject: | [PEPr] Comment on Math::Math_AP_(Re-proposal) | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41648@lists.php.net to get a copy of this message | ||
bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for
Math::Math_AP_(Re-proposal).
Comment:
Few more:
* first version *must* be 0.1.0
* PHP license version 2.0 is no more allowed
* please use the current format for headers and correct the copyright
dates
* you need to check the return value of gzopen, in no case you can be sure
it will be there and valid
* don't require 'PEAR.php' absolutely only for errors, better do a wrapper
which will require it and raise the error.
* give a more detailled description in package.xml
* I have the feeling that the number of iterations you do in the methods
is very arbitrary and not related to the scale, why these $scale +100, +50
or +20 ? I was more expecting some convergence tests
* more generally, you don't seem to target some performance.
* do you have some references for the algorithms you use ?
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=352
--
Sent by PEPr, the automatic proposal system at http://pear.php.net