Re: Invitation for comments on Validate_IN
| From: | Pierre | Date: | Sat, 18 Mar 2006 02:44:31 +0000 |
| Subject: | Re: Invitation for comments on Validate_IN | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-41853@lists.php.net to get a copy of this message | ||
On 3/18/06, Anant Narayanan <anant@kix.in> wrote:
> Hello All,
>
> I just completed a trivial package for locale validation in India. I
> have proposed the package on PEAR, and invite comments on it.
>
> http://pear.php.net/pepr/pepr-proposal-show.php?id=373
There is no need of a proposal for Validate, they are only subpackages.
Please make the code php4 compatible as well, there is no need to use
public and static here. The stateCode method should return boolean as
well, you can provide an extra method to return the name respectively
the code.
Do you have some tests as well?
Once you have done these changes, please mail me again.
--Pierre