Re: [PEPr] Call for Comments: Structures_Form

Scott, > I would like to hear more comments/suggestions for Structures_Form and > Structures_Form_Gtk2. It looks good. Just a note: "Unfreezes the element so that its value may not be changed." in the Gtk2Text.php isn't the correct description. Gtk2_FileSelect: > It is highly unlikely that a user really wants to clear the value of a > button. Therefore, this method has been deactivated. It will always > return true. If the user really wants to clear the value, they can > pass null to setValue() That isn't correct - set_value returns false if the dir doesn't exist, and NULL doesn't exist as file. Btw, does setting the dir to "/" work on windows? Gtk2Date.php: It would be nice to have a constructor parameter that determines how months are displayed. Not all people may want to have the month name displayed. And it's currently not possible to change the year span displayed for selection. Too bad that php doesn't allow multiple inheritance - it would have saved lots of repeated setLabel/getLabel/... methods. -- Regards/MfG, Christian Weiske

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc