Re: [PEPr] +1 for XML::Query2XML
| From: | Hannes Magnusson | Date: | Sat, 15 Apr 2006 12:26:34 +0000 |
| Subject: | Re: [PEPr] +1 for XML::Query2XML | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42246@lists.php.net to get a copy of this message | ||
I do have couple of comments:
in _hasDOMChild() would be easier to simply:
return (bool)$element->getElementsByTagName($childTagName)->length;
(Or remove bool and return how many elements it found).
Same goes for _getDOMChild():
$domNodeList = $element->getElementsByTagName($childTagName);
if($domNodeList->length) {
return $domNodeList->item(0);
}
And at last; there are few times you use while(list($key, $value) =
each($array));
I belive the CS wants it to be foreach($array as $key => $value);
- Hannes
On 15 Apr 2006 12:12:45 -0000, Hannes Magnusson <bjori@php.net> wrote:
>
> Hannes Magnusson (http://pear.php.net/user/bjori) has voted +1 on the proposal for
> XML::Query2XML.
>
> Proposal information:
> http://pear.php.net/pepr/pepr-proposal-show.php?id=361
> Vote information:
>
> http://pear.php.net/pepr/pepr-vote-show.php?id=361&handle=bjori
>
> --
> Sent by PEPr, the automatic proposal system at €Ôf›òõè↧
> Oû´http://pear.php.net
>