[PEPr] Comment on HTTP::Sync
| From: | Matthew Weier O'Phinney | Date: | Wed, 31 May 2006 17:10:19 +0000 |
| Subject: | [PEPr] Comment on HTTP::Sync | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-42717@lists.php.net to get a copy of this message | ||
Matthew Weier O'Phinney (http://pear.php.net/user/weierophinney) has commented on the proposal
for HTTP::Sync.
Comment:
* s/syncronize/synchronize/
* Don't use is_object() to check for errors; use PEAR::isError()
* How will you deal with differences in timezones between a web server and
the local filesystem?
* Use require_once instead of include_once. In each instance that you use
it, it would be better to raise a fatal error on loading the class file
than to later get it when the class isn't found. (Die early)
* In HTTP_Sync_Download::raiseError, use __CLASS__ instead of the string
'HTTP::Sync::Download'.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=402
--
Sent by PEPr, the automatic proposal system at http://pear.php.net